Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alemba vFire alert to GUI #1100

Merged
merged 18 commits into from Dec 20, 2018
Merged

Conversation

@swaterkamp
Copy link
Member

swaterkamp commented Dec 18, 2018

No description provided.

@swaterkamp swaterkamp self-assigned this Dec 18, 2018
@swaterkamp swaterkamp requested a review from timopollmeier Dec 18, 2018
@swaterkamp swaterkamp requested a review from bjoernricks as a code owner Dec 18, 2018
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 18, 2018

Codecov Report

Merging #1100 into master will decrease coverage by 0.02%.
The diff coverage is 8.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1100      +/-   ##
==========================================
- Coverage    15.1%   15.08%   -0.03%     
==========================================
  Files         832      833       +1     
  Lines       26877    26967      +90     
  Branches     5663     5705      +42     
==========================================
+ Hits         4061     4069       +8     
- Misses      21412    21490      +78     
- Partials     1404     1408       +4
Impacted Files Coverage Δ
gsa/src/web/pages/credentials/dialog.js 0% <0%> (ø) ⬆️
gsa/src/gmp/commands/alerts.js 7.89% <0%> (-0.22%) ⬇️
gsa/src/web/pages/alerts/dialog.js 0% <0%> (ø) ⬆️
gsa/src/web/pages/alerts/component.js 0% <0%> (ø) ⬆️
gsa/src/web/pages/alerts/alembavfiremethodpart.js 0% <0%> (ø)
gsa/src/web/pages/alerts/method.js 0% <0%> (ø) ⬆️
gsa/src/gmp/models/alert.js 100% <100%> (ø) ⬆️
gsa/src/gmp/models/credential.js 98.18% <66.66%> (-1.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47becd3...4533309. Read the comment docs.

@swaterkamp swaterkamp force-pushed the swaterkamp:AlembaVFire branch from 296e69a to 644eacf Dec 19, 2018
@swaterkamp swaterkamp force-pushed the swaterkamp:AlembaVFire branch from 8a34416 to 843fa9b Dec 19, 2018
@swaterkamp swaterkamp force-pushed the swaterkamp:AlembaVFire branch from 843fa9b to 2af51f3 Dec 20, 2018
Copy link
Contributor

timopollmeier left a comment

Thanks! It works for me but maybe @bjoernricks should also check the code before merging.

@timopollmeier timopollmeier merged commit 165d724 into greenbone:master Dec 20, 2018
1 of 3 checks passed
1 of 3 checks passed
codecov/patch 8.69% of diff hit (target 15.1%)
Details
codecov/project 15.08% (-0.03%) compared to 47becd3
Details
build_and_test Workflow: build_and_test
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.