Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add errordialog to fix missing error messages in trashcan #1286

Merged
merged 4 commits into from Apr 16, 2019

Conversation

@sarahd93
Copy link
Contributor

sarahd93 commented Apr 16, 2019

Checklist:

@codecov

This comment has been minimized.

Copy link

codecov bot commented Apr 16, 2019

Codecov Report

Merging #1286 into gsa-8.0 will increase coverage by 0.03%.
The diff coverage is 40.74%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1286      +/-   ##
===========================================
+ Coverage       18%   18.03%   +0.03%     
===========================================
  Files          952      953       +1     
  Lines        27663    27683      +20     
  Branches      5988     5982       -6     
===========================================
+ Hits          4982     4994      +12     
- Misses       21275    21284       +9     
+ Partials      1406     1405       -1
Impacted Files Coverage Δ
gsa/src/web/pages/extras/trashcanpage.js 0% <0%> (ø) ⬆️
gsa/src/web/components/dialog/errordialog.js 100% <100%> (ø)
gsa/src/web/components/dialog/footer.js 100% <0%> (+25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9089c68...06d2702. Read the comment docs.

@sarahd93 sarahd93 marked this pull request as ready for review Apr 16, 2019
@sarahd93 sarahd93 requested review from bjoernricks, swaterkamp and greenbone/gsa-dev as code owners Apr 16, 2019
@sarahd93 sarahd93 force-pushed the sarahd93:trashcan_gsa8 branch from a859249 to 8fb3875 Apr 16, 2019
{error && (
<ErrorDialog
text={error.message}
title="Error"

This comment has been minimized.

Copy link
@bjoernricks

bjoernricks Apr 16, 2019

Member
Suggested change
title="Error"
title={_('Error')}
expect(handleClose).toHaveBeenCalled();
});

/* test('should close ErrorDialog with cancel button', () => {

This comment has been minimized.

Copy link
@bjoernricks

bjoernricks Apr 16, 2019

Member

Test code should be removed

@sarahd93 sarahd93 requested a review from bjoernricks Apr 16, 2019
@bjoernricks bjoernricks merged commit 5701013 into greenbone:gsa-8.0 Apr 16, 2019
3 checks passed
3 checks passed
build_and_test Workflow: build_and_test
Details
codecov/patch 40.74% of diff hit (target 18%)
Details
codecov/project 18.03% (+0.03%) compared to 9089c68
Details
@sarahd93 sarahd93 deleted the sarahd93:trashcan_gsa8 branch Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.