Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd errordialog to fix missing error messages in trashcan #1286
Conversation
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Apr 16, 2019
•
Codecov Report
@@ Coverage Diff @@
## gsa-8.0 #1286 +/- ##
===========================================
+ Coverage 18% 18.03% +0.03%
===========================================
Files 952 953 +1
Lines 27663 27683 +20
Branches 5988 5982 -6
===========================================
+ Hits 4982 4994 +12
- Misses 21275 21284 +9
+ Partials 1406 1405 -1
Continue to review full report at Codecov.
|
sarahd93
requested review from
bjoernricks,
swaterkamp and
greenbone/gsa-dev
as
code owners
| {error && ( | ||
| <ErrorDialog | ||
| text={error.message} | ||
| title="Error" |
This comment has been minimized.
This comment has been minimized.
| expect(handleClose).toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| /* test('should close ErrorDialog with cancel button', () => { |
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
sarahd93 commentedApr 16, 2019
Checklist: