Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some translation bugs #1407

Merged
merged 5 commits into from May 16, 2019

Conversation

@sarahd93
Copy link
Contributor

sarahd93 commented May 15, 2019

Checklist:

@codecov

This comment has been minimized.

Copy link

codecov bot commented May 15, 2019

Codecov Report

Merging #1407 into gsa-8.0 will decrease coverage by 0.16%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1407      +/-   ##
===========================================
- Coverage    36.68%   36.51%   -0.17%     
===========================================
  Files          960      960              
  Lines        21739    21678      -61     
  Branches      6039     6011      -28     
===========================================
- Hits          7974     7915      -59     
+ Misses       12434    12432       -2     
  Partials      1331     1331
Impacted Files Coverage Δ
gsa/src/web/pages/notes/table.js 18.18% <ø> (ø) ⬆️
gsa/src/web/pages/cves/table.js 27.77% <ø> (ø) ⬆️
gsa/src/web/pages/users/header.js 18.18% <ø> (ø) ⬆️
gsa/src/web/pages/operatingsystems/table.js 23.52% <ø> (ø) ⬆️
...rc/web/pages/scanconfigs/editconfigfamilydialog.js 6.66% <ø> (ø) ⬆️
gsa/src/web/pages/vulns/table.js 23.8% <ø> (ø) ⬆️
gsa/src/web/pages/reports/operatingsystemstable.js 36.36% <ø> (ø) ⬆️
gsa/src/web/pages/secinfo/table.js 25% <ø> (ø) ⬆️
gsa/src/web/pages/portlists/table.js 16.66% <ø> (ø) ⬆️
gsa/src/web/pages/reports/cvestable.js 33.33% <ø> (ø) ⬆️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8eb5d9...ade8966. Read the comment docs.

@sarahd93 sarahd93 marked this pull request as ready for review May 15, 2019
@sarahd93 sarahd93 requested review from bjoernricks, swaterkamp and greenbone/gsa-dev as code owners May 15, 2019
@bjoernricks bjoernricks merged commit 9f31b34 into greenbone:gsa-8.0 May 16, 2019
1 check passed
1 check passed
build_and_test Workflow: build_and_test
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.