Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Improve Loading Indicator #1469

Merged
merged 4 commits into from Jul 8, 2019

Conversation

@swaterkamp
Copy link
Member

swaterkamp commented Jul 8, 2019

  • Fix showing Loading indicator at entities pages
  • Redesign and brand the Loading indicator

Checklist:

@swaterkamp swaterkamp requested a review from bjoernricks as a code owner Jul 8, 2019
@swaterkamp swaterkamp self-assigned this Jul 8, 2019
@swaterkamp swaterkamp changed the base branch from master to gsa-8.0 Jul 8, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jul 8, 2019

Codecov Report

Merging #1469 into gsa-8.0 will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1469      +/-   ##
===========================================
+ Coverage    37.35%   37.36%   +<.01%     
===========================================
  Files          963      963              
  Lines        21815    21810       -5     
  Branches      6092     6090       -2     
===========================================
  Hits          8150     8150              
+ Misses       12368    12363       -5     
  Partials      1297     1297
Impacted Files Coverage Δ
gsa/src/web/components/loading/loading.js 100% <ø> (ø) ⬆️
gsa/src/web/entities/page.js 6.52% <0%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79939fa...2b34276. Read the comment docs.

@swaterkamp swaterkamp merged commit 4b72385 into greenbone:gsa-8.0 Jul 8, 2019
6 of 7 checks passed
6 of 7 checks passed
codecov/patch 0% of diff hit (target 37.35%)
Details
build_and_test Workflow: build_and_test
Details
ci/circleci: build_gsa Your tests passed on CircleCI!
Details
ci/circleci: build_gsad Your tests passed on CircleCI!
Details
ci/circleci: js_lint Your tests passed on CircleCI!
Details
ci/circleci: js_test Your tests passed on CircleCI!
Details
codecov/project 37.36% (+<.01%) compared to 79939fa
Details
@swaterkamp swaterkamp deleted the swaterkamp:loading branch Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.