Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bullet point separator to horizontal lists #1494

Merged
merged 10 commits into from Jul 23, 2019

Conversation

@saberlynx
Copy link
Contributor

saberlynx commented Jul 19, 2019

Checklist:

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jul 19, 2019

Codecov Report

Merging #1494 into master will decrease coverage by 0.07%.
The diff coverage is 34.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1494      +/-   ##
==========================================
- Coverage    37.1%   37.03%   -0.08%     
==========================================
  Files         999      999              
  Lines       22283    22294      +11     
  Branches     6121     6133      +12     
==========================================
- Hits         8268     8256      -12     
- Misses      12702    12724      +22     
- Partials     1313     1314       +1
Impacted Files Coverage Δ
gsa/src/web/pages/filters/details.js 20% <0%> (-2.23%) ⬇️
gsa/src/web/pages/users/details.js 14.28% <0%> (-1.1%) ⬇️
gsa/src/web/pages/groups/details.js 33.33% <0%> (-6.67%) ⬇️
gsa/src/web/pages/targets/details.js 9.67% <0%> (-0.33%) ⬇️
gsa/src/web/pages/roles/details.js 33.33% <0%> (-6.67%) ⬇️
gsa/src/web/pages/alerts/details.js 7.14% <0%> (-0.27%) ⬇️
gsa/src/web/pages/notes/details.js 9.09% <0%> (-0.44%) ⬇️
gsa/src/web/pages/credentials/details.js 8.33% <0%> (-0.76%) ⬇️
gsa/src/web/pages/tasks/details.js 5% <0%> (-0.07%) ⬇️
gsa/src/web/pages/overrides/details.js 9.09% <0%> (-0.44%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b49b621...ff212e6. Read the comment docs.

@saberlynx saberlynx marked this pull request as ready for review Jul 19, 2019
Copy link
Member

bjoernricks left a comment

I really would like to introduce an own component for displaying the bullet. With an own component it is easier to change the behavior in future.

saberlynx added 2 commits Jul 22, 2019
…nges to report formats because its wrong
@saberlynx

This comment has been minimized.

Copy link
Contributor Author

saberlynx commented Jul 22, 2019

I really would like to introduce an own component for displaying the bullet. With an own component it is easier to change the behavior in future.

I added it. I still have to write a test for the horizontalsep component. I have some options in there because I already wrote them :P

saberlynx added 2 commits Jul 22, 2019
@bjoernricks bjoernricks self-requested a review Jul 23, 2019
@bjoernricks bjoernricks merged commit b553975 into greenbone:master Jul 23, 2019
6 checks passed
6 checks passed
build_and_test Workflow: build_and_test
Details
ci/circleci: build_gsa Your tests passed on CircleCI!
Details
ci/circleci: build_gsad Your tests passed on CircleCI!
Details
ci/circleci: c_check_format Your tests passed on CircleCI!
Details
ci/circleci: js_lint Your tests passed on CircleCI!
Details
ci/circleci: js_test Your tests passed on CircleCI!
Details
@bjoernricks bjoernricks mentioned this pull request Jul 23, 2019
@saberlynx saberlynx deleted the saberlynx:listSep branch Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.