Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ical date recurrence fix #1539

Merged
merged 7 commits into from Aug 5, 2019

Conversation

@bjoernricks
Copy link
Member

bjoernricks commented Aug 2, 2019

Fix calculating the next date of a schedule ical event. ical times are evil 馃懣

Checklist:

bjoernricks added 2 commits Aug 2, 2019
ical times are very dangerous to use. Use moment.js to create a current
datetime object and compare the unix timestamps (which is always in UTC)
for getting the due date.
@bjoernricks bjoernricks marked this pull request as ready for review Aug 2, 2019
@bjoernricks bjoernricks requested review from swaterkamp and greenbone/gsa-dev as code owners Aug 2, 2019
bjoernricks added 2 commits Aug 2, 2019
Don't log warning if ical.js raised error due to finding same dates
which can happen due to 30 and last day are contained in the recurrence
rule.
@bjoernricks bjoernricks force-pushed the bjoernricks:ical-date-recurrence-fix branch from 129bc0a to 518d92a Aug 5, 2019
swaterkamp added 2 commits Aug 5, 2019
@swaterkamp swaterkamp self-requested a review Aug 5, 2019
@swaterkamp swaterkamp merged commit 8fe6527 into greenbone:gsa-8.0 Aug 5, 2019
7 checks passed
7 checks passed
build_and_test Workflow: build_and_test
Details
ci/circleci: build_gsa Your tests passed on CircleCI!
Details
ci/circleci: build_gsad Your tests passed on CircleCI!
Details
ci/circleci: js_lint Your tests passed on CircleCI!
Details
ci/circleci: js_test Your tests passed on CircleCI!
Details
codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
@bjoernricks bjoernricks deleted the bjoernricks:ical-date-recurrence-fix branch Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.