New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update invalid url handling #1603
Merged
bjoernricks
merged 7 commits into
greenbone:gsa-8.0
from
bjoernricks:update-invalid-url-handling
Sep 3, 2019
Merged
Update invalid url handling #1603
bjoernricks
merged 7 commits into
greenbone:gsa-8.0
from
bjoernricks:update-invalid-url-handling
Sep 3, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All unknown urls will now return the index.html page and the js code will handle them accordingly. Thus the whole url handling besides /gmp, /system_report and static files is done in js now.
Be even more restrictive by not including user URL in 404 response.
Don't send 404 page if the url start with two slashes. Instead it is an invalid request.
The function is unsed now.
The url param isn't used anymore.
swaterkamp
approved these changes
Sep 3, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my(!) point of view, this looks ok.
timopollmeier
approved these changes
Sep 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fix #1601 and use js to handle nearly all urls now.