Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert glamorous to styled-components #7 #925

Merged
merged 22 commits into from Sep 11, 2018

Conversation

@swaterkamp
Copy link
Member

swaterkamp commented Sep 11, 2018

Contributes to #643

@swaterkamp swaterkamp self-assigned this Sep 11, 2018
@swaterkamp swaterkamp requested a review from bjoernricks Sep 11, 2018
@swaterkamp swaterkamp force-pushed the swaterkamp:glamorous2styledcomponents branch from 172e458 to 5ed7895 Sep 11, 2018
@codecov

This comment has been minimized.

Copy link

codecov bot commented Sep 11, 2018

Codecov Report

Merging #925 into master will increase coverage by <.01%.
The diff coverage is 1.12%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #925      +/-   ##
=========================================
+ Coverage    7.49%   7.49%   +<.01%     
=========================================
  Files         826     826              
  Lines       26908   26907       -1     
  Branches     5713    5737      +24     
=========================================
  Hits         2018    2018              
+ Misses      22443   22441       -2     
- Partials     2447    2448       +1
Impacted Files Coverage Δ
gsa/src/web/pages/alerts/method.js 0% <0%> (ø) ⬆️
gsa/src/web/entities/withRowDetails.js 0% <0%> (ø) ⬆️
gsa/src/web/entity/override.js 0% <0%> (ø) ⬆️
gsa/src/web/entities/table.js 0% <0%> (ø) ⬆️
gsa/src/web/entities/tagsdialog.js 0% <0%> (ø) ⬆️
gsa/src/web/components/section/header.js 0% <0%> (ø) ⬆️
gsa/src/web/components/sortby/sortby.js 0% <0%> (ø) ⬆️
gsa/src/web/entity/info.js 0% <0%> (ø) ⬆️
gsa/src/web/components/pagination/pagination.js 0% <0%> (ø) ⬆️
gsa/src/web/entity/tags.js 0% <0%> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5e594e...5ed7895. Read the comment docs.

@bjoernricks bjoernricks merged commit 9311029 into greenbone:master Sep 11, 2018
5 of 6 checks passed
5 of 6 checks passed
codecov/patch 1.12% of diff hit (target 7.49%)
Details
ci/circleci: build_gsa Your tests passed on CircleCI!
Details
ci/circleci: build_gsad Your tests passed on CircleCI!
Details
ci/circleci: js_lint Your tests passed on CircleCI!
Details
ci/circleci: js_test Your tests passed on CircleCI!
Details
codecov/project 7.49% (+<.01%) compared to f5e594e
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.