Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert glamorous to styled-components #12 #950

Merged
merged 13 commits into from Sep 19, 2018

Conversation

@swaterkamp
Copy link
Member

swaterkamp commented Sep 18, 2018

Converts stories for storybook to styled-components and removes glamorous dependencies.

Contributes to and finally closes #643

@swaterkamp swaterkamp self-assigned this Sep 18, 2018
@swaterkamp swaterkamp requested a review from bjoernricks Sep 18, 2018
@swaterkamp swaterkamp requested a review from greenbone/gsa-dev as a code owner Sep 18, 2018
@bjoernricks bjoernricks merged commit 1b9f018 into greenbone:master Sep 19, 2018
6 checks passed
6 checks passed
ci/circleci: build_gsa Your tests passed on CircleCI!
Details
ci/circleci: build_gsad Your tests passed on CircleCI!
Details
ci/circleci: js_lint Your tests passed on CircleCI!
Details
ci/circleci: js_test Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 7bc2f6a...b031cad
Details
codecov/project 8.84% remains the same compared to 7bc2f6a
Details
@swaterkamp swaterkamp deleted the swaterkamp:glamorous2styledcomponents branch Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.