Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #207 #208

Merged
merged 1 commit into from Mar 28, 2019

Conversation

@kroosec
Copy link
Contributor

kroosec commented Mar 27, 2019

Use a dynamic array for gvm_hosts instead of doubly-linked lists.

This substantially improves handling of large sets of hosts.
ie. With a "10.0.0.0/8" hosts string, memory footprint is reduced from
1.33GB to 0.9GB. Other operations times such as creation and shuffling
are also slightly faster.

Backport of #207

This substantially improves handling of large sets of hosts.
ie. With a "10.0.0.0/8" hosts string, memory footprint is reduced from
1.33GB to 0.9GB. Other operations times such as creation and shuffling
are also slightly faster.
@kroosec kroosec requested a review from jjnicola Mar 27, 2019
@kroosec kroosec requested a review from greenbone/gvm-dev as a code owner Mar 27, 2019
Copy link
Member

jjnicola left a comment

It seems you pushed to the wrong branch.

@kroosec kroosec changed the base branch from master to gvm-libs-1.0 Mar 28, 2019
@jjnicola jjnicola merged commit 680d0c1 into greenbone:gvm-libs-1.0 Mar 28, 2019
3 checks passed
3 checks passed
build_and_test Workflow: build_and_test
Details
codecov/patch 100% of diff hit (target 96.45%)
Details
codecov/project Absolute coverage decreased by -0.01% but relative coverage increased by +3.54% compared to 9a90046
Details
@cfi-gb

This comment has been minimized.

Copy link
Member

cfi-gb commented Mar 29, 2019

In 680d0c1#commitcomment-32956396 it was noticed that the build is failing with:

/root/openvas-src/gvmd/gvmd/src/manage_utils.c:744:49: error: '*find_hosts->hosts' is a pointer; did you mean to use '->'?                                           
   int ret = gvm_host_in_hosts (find_hosts->hosts->data, NULL, hosts);                                                                                               
                                                 ^~                                                                                                                  
                                                 ->
@kroosec kroosec mentioned this pull request Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.