Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cgreen based unit tests for gvmd #579

Merged
merged 13 commits into from Jun 14, 2019

Conversation

@mattmundell
Copy link
Contributor

commented Jun 4, 2019

Exploring Cgreen as an option for gvmd unit tests.

@mattmundell mattmundell changed the title Unit tests cgreen CGreen based unit tests for gvmd Jun 4, 2019
@mattmundell mattmundell changed the title CGreen based unit tests for gvmd Cgreen based unit tests for gvmd Jun 4, 2019
@bjoernricks

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

👍 👍 👍 really nice!

mattmundell added 9 commits Jun 4, 2019
This adds a test for create_ticket_run, which is complex because
create_ticket_run calls into other parts of the gvmd code (copy_ticket,
ticket_uuid, log_event, etc).

The test creates 'mock' versions of those functions.

A gcc attribute is used as an easy way to override the mocked functions.
The alternative would be to link against less of the gvmd code and to
fill the gaps with stub functions.  But our code is not very cleanly
separated to this is a lot of work.  Should get easier as we clean
things up, if the attribute is not suitable.
This test requires a system function to be wrapped, and specifies the
return of the system function in the test (which is more usefull than
specifying it in the wrapper).
@mattmundell mattmundell marked this pull request as ready for review Jun 10, 2019
@mattmundell mattmundell requested a review from greenbone/gvm-dev as a code owner Jun 10, 2019
@mattmundell mattmundell requested review from jjnicola and timopollmeier Jun 10, 2019
Copy link
Contributor

left a comment

For me gmp-tickets-test fails with a segmentation fault.
See the comment in src/gmp_tickets_tests.c for what I found with a quick gdb stack trace.

src/gmp_tickets_tests.c Show resolved Hide resolved
@mattmundell mattmundell requested a review from timopollmeier Jun 13, 2019
@mattmundell mattmundell merged commit 65ad517 into greenbone:master Jun 14, 2019
13 of 15 checks passed
13 of 15 checks passed
codecov/patch 24.32% of diff hit (target 93.08%)
Details
codecov/project 92.6% (-0.48%) compared to ddc7c4b
Details
build Workflow: build
Details
ci/circleci: build_doc Your tests passed on CircleCI!
Details
ci/circleci: build_postgresql_debug Your tests passed on CircleCI!
Details
ci/circleci: build_postgresql_debug_clang Your tests passed on CircleCI!
Details
ci/circleci: build_postgresql_release Your tests passed on CircleCI!
Details
ci/circleci: build_sqlite3_debug_clang Your tests passed on CircleCI!
Details
ci/circleci: build_sqlite_debug Your tests passed on CircleCI!
Details
ci/circleci: build_sqlite_release Your tests passed on CircleCI!
Details
ci/circleci: check_format Your tests passed on CircleCI!
Details
ci/circleci: doc_coverage Your tests passed on CircleCI!
Details
ci/circleci: gen_xml_doc Your tests passed on CircleCI!
Details
ci/circleci: scan_build_postgresql_debug Your tests passed on CircleCI!
Details
ci/circleci: scan_build_sqlite3_debug Your tests passed on CircleCI!
Details
@mattmundell mattmundell deleted the mattmundell:unit-tests-cgreen branch Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.