additional warnings #1025
Merged
additional warnings #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nichtsfrei
force-pushed
the
additional-warnings
branch
6 times, most recently
from
dcba9d8
to
f7f71d1
Compare
nichtsfrei
force-pushed
the
additional-warnings
branch
from
2fd2539
to
6e349c0
Compare
Kraemii
reviewed
Feb 11, 2022
Kraemii
reviewed
Feb 11, 2022
nichtsfrei
force-pushed
the
additional-warnings
branch
from
548d0da
to
8492f16
Compare
y0urself
reviewed
Feb 14, 2022
nichtsfrei
force-pushed
the
additional-warnings
branch
from
8492f16
to
1729132
Compare
Kraemii
previously approved these changes
Feb 14, 2022
Kraemii
approved these changes
Feb 15, 2022
Add: -Wextra -Werror -Wpedantic -Wmissing-prototypes -Wshadow -Wsequence-point -fsanitize=address compile flags and fixed misc accordingly.
Contains definition of ``` tree_cell * nasl_lint (lex_ctxt *lexic, tree_cell *st); ``` because it is used in exec as well.
Co-authored-by: Christoph Krämer <christoph.kraemer@greenbone.net>
nichtsfrei
force-pushed
the
additional-warnings
branch
from
04f33ff
to
2aa1ca7
Compare
ArnoStiefvater
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor: add stricter compile options to find common issues
Add:
-Wextra
-Werror
-Wpedantic
-Wmissing-prototypes
-Wshadow
-Wsequence-point
compile flags and fixed misc accordingly.
This in coordination with SC-270.