Omit timestamp from PE executable #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! Would be nice if you could do a quick changelog entry |
|
Note that this code might be also a candidate for complete removal, ref: #24 |
|
Added a changelog entry. Removal would also be fine for reproducible builds. |
y0urself
previously requested changes
Jun 14, 2021
to make binaries reproducible. See https://reproducible-builds.org/ for why this is good. This PR was done while working on reproducible builds for openSUSE. Co-authored-by: Jaspar L. <jaspar.loechte@greenbone.net>
bjoernricks
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Omit timestamp from PE executable
to make binaries reproducible.
See https://reproducible-builds.org/ for why this is good.
This PR was done while working on reproducible builds for openSUSE.