Fix: make scanner preferences visible (#1049)

* Add: make visible to clients two scanner preferences that were only available via openvas.conf configuration file

* fix test

Author: jjnicola

ospd_openvas/daemon.py

@@ -302,6 +302,29 @@
             + 'packet was sent.'
         ),
     },
+    'icmp_retries': {
+        'type': 'integer',
+        'name': 'icmp_retries',
+        'default': 1,
+        'mandatory': 0,
+        'visible_for_client': True,
+        'description': (
+            'This is the default amount of icmp packets that will be '
+            + 'sent to the host target during an alive test.'
+        ),
+    },
+    'icmp_grace_period': {
+        'type': 'integer',
+        'name': 'icmp_grace_period',
+        'default': 0,
+        'mandatory': 0,
+        'visible_for_client': True,
+        'description': (
+            'Wait time between icmp packets during alive tests. '
+            + 'Useful for sensitive targets. It can slow '
+            + 'down the alive test.'
+        ),
+    },
     'hosts_allow': {
         'type': 'string',
         'name': 'hosts_allow',

tests/test_daemon.py

@@ -270,6 +270,29 @@
             + 'packet was sent.'
         ),
     },
+    'icmp_retries': {
+        'type': 'integer',
+        'name': 'icmp_retries',
+        'default': 1,
+        'mandatory': 0,
+        'visible_for_client': True,
+        'description': (
+            'This is the default amount of icmp packets that will be '
+            + 'sent to the host target during an alive test.'
+        ),
+    },
+    'icmp_grace_period': {
+        'type': 'integer',
+        'name': 'icmp_grace_period',
+        'default': 0,
+        'mandatory': 0,
+        'visible_for_client': True,
+        'description': (
+            'Wait time between icmp packets during alive tests. '
+            + 'Useful for sensitive targets. It can slow '
+            + 'down the alive test.'
+        ),
+    },
     'hosts_allow': {
         'type': 'string',
         'name': 'hosts_allow',