New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode citation_ids using base62 #305

Merged
merged 2 commits into from Apr 13, 2017

Conversation

Projects
None yet
2 participants
@dhimmel
Member

dhimmel commented Apr 11, 2017

Builds off of the merged #298.

Thanks @suminb for adding the ability to base62 encode bytes in suminb/base62#6!

I switched to 6-byte hash... now the probability of collision with 1 million references is 0.18%.

Builds will still fail until the Crossref API issues are fixed CrossRef/rest-api-doc#194

dhimmel added some commits Apr 11, 2017

CSL: remove malformated event field
The event field of CSL data should be a string (https://git.io/vSSug).

Instead the event key returns an object as shown below:

```sh
curl --location \
  --header "Accept: application/vnd.citationstyles.csl+json" \
  https://doi.org/10.1109/icnn.1994.374637 \
  | python -m json.tool
```

```json
"event": {
    "name": "1994 IEEE International Conference on Neural Networks (ICNN'94)",
    "location": "Orlando, FL, USA",
    "acronym": "ICNN-94"
},
```

Related to CrossRef/rest-api-doc#187.
DOI content negotiation returns invalid CSL

@dhimmel dhimmel merged commit bc4b817 into greenelab:master Apr 13, 2017

2 checks passed

codeclimate no new or fixed issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dhimmel dhimmel deleted the dhimmel:base62 branch Apr 13, 2017

@dhimmel

This comment has been minimized.

Member

dhimmel commented Apr 13, 2017

@agitter all the build problems have been resolved. The new citation_id format is in effect and visible in https://greenelab.github.io/deep-review/.

You can see what the base62 encoded hashes look like in the citation_id column of processed-citations.tsv. Quite beautiful.

@agitter

This comment has been minimized.

Collaborator

agitter commented Apr 13, 2017

Quite beautiful indeed. Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment