Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments from review of initial submission #124

Closed
10 tasks done
ctb opened this issue Feb 5, 2019 · 15 comments
Closed
10 tasks done

Comments from review of initial submission #124

ctb opened this issue Feb 5, 2019 · 15 comments

Comments

@ctb
Copy link

@ctb ctb commented Feb 5, 2019

review comments/requests: see

  • Strengthen statement about "no objective system " for authorship #123
  • further emphasize strikethrough formatting for errors in extant versions #122
  • maybe add a note about how manubot could be used for better lesson development #120
  • "it is reviewed by a maintainer and a participant" #119
  • "We use GitHub issues for organization" #118
  • "requesting modifications as depicted in 7." #117
  • do rendered versions of each PR get posted back to the PR? #121
  • footnote placement in rendered manuscript should be left-adjusted #116
  • introductory paragraph needs more citations. #114
  • "correctness and fairness" in abstract are unclear. #115

note these refer to the submitted version of this paper that I received in PDF form; will need to be double checked against latest version.

@tpoisot
Copy link

@tpoisot tpoisot commented Feb 5, 2019

I'd need to read a bit more to comment - just to be clear, is that an invitation to give feedback? I would be happy to, but I'm on parental leave until March.

Loading

@ctb
Copy link
Author

@ctb ctb commented Feb 5, 2019

Loading

@slochower
Copy link
Collaborator

@slochower slochower commented Feb 5, 2019

@ctb Yep, got it, sorry for the confusion. I was a little slow on figuring out what was going on.

Loading

@ctb
Copy link
Author

@ctb ctb commented Feb 5, 2019

Loading

@ctb ctb changed the title review review review review meta issue Comments from review of initial submission Feb 7, 2019
@ctb
Copy link
Author

@ctb ctb commented Feb 7, 2019

description & issue title fixed. please leave me to update the checkboxes for second review!

Loading

@agitter
Copy link
Collaborator

@agitter agitter commented Feb 7, 2019

Thanks for the comments and for reorganizing the issue @ctb. Would you like us to have you review the pull requests that we create to close these issues? That would ensure we're addressing the comments properly, but I also don't want to commit you to more frequent reviewing if that isn't your intention.

Loading

@ctb
Copy link
Author

@ctb ctb commented Feb 7, 2019

Loading

@slochower
Copy link
Collaborator

@slochower slochower commented Feb 7, 2019

@dhimmel @agitter Do you want to assign specific people to tackle specific issues or some other alternative strategy?

Loading

@dhimmel
Copy link
Contributor

@dhimmel dhimmel commented Feb 7, 2019

Do you want to assign specific people to tackle specific issues or some other alternative strategy?

How about first one to volunteer or open a PR addressing a piece of feedback gets it. Let's try to keep PRs small, review fast, and merges frequent. @agitter did you want to create response-to-reviewers.md or should I?

Loading

@agitter
Copy link
Collaborator

@agitter agitter commented Feb 7, 2019

@agitter did you want to create response-to-reviewers.md or should I?

I'm on it now. Sooo many meetings this week.

Loading

@agitter
Copy link
Collaborator

@agitter agitter commented Feb 9, 2019

My plan for this issue is to start making pull requests to address the individual comments and close the respective issues. Once they are all finished, we can discuss the batch of changes here and reopen issues that need more revisions.

Loading

@dhimmel dhimmel pinned this issue Mar 28, 2019
@agitter
Copy link
Collaborator

@agitter agitter commented Apr 3, 2019

@ctb thank you for all of your feedback on the Manubot manuscript and organizing it in issues. We're getting close to resubmitting. Is it okay with you if we acknowledge your public review (#126)?

We have also been checking the boxes above to help us track what still needs attention. We're happy to discuss individual comments with you any time.

Loading

@ctb
Copy link
Author

@ctb ctb commented Apr 3, 2019

Loading

@dhimmel
Copy link
Contributor

@dhimmel dhimmel commented Apr 6, 2019

Looks like we have made revisions to address each of the issues above.

We can leave this open for @ctb to close if he agrees we've addressed the issues?

Loading

@agitter
Copy link
Collaborator

@agitter agitter commented Apr 12, 2019

Closing this as part of the v3.0 submission. We could reopen or make new issues for additional discussion.

Loading

@agitter agitter closed this Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants