Properly set attribute inheritance for external tables #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielgustafsson
force-pushed
the
exttable_inherit_att
branch
from
6ea4f7d
to
3190cbf
Compare
|
Is this pull request ready to be merged? |
|
It's ready for review. |
|
Any concerns or thoughts here @jimmyyih or @HaozhouWang (folks who've touched this code recentlyish)? |
|
@xiong-gang would you please take a look at this PR? |
|
It is look good to me. |
danielgustafsson
force-pushed
the
exttable_inherit_att
branch
from
3190cbf
to
47e5f46
Compare
External tables doesn't support attribute inheritance, and while there is no syntax to trick plain inheritance into happening it was possible to get inherited attributes by injecting an external table into a partition hierarchy via partition exchange. Commit fcdd853 attempted to fix this but was erroneous and subsequently reverted. The problem with that commit was that it broke off the inheritance chain too early, the partition still need inheritance to become part of the hierarchy. This commit essentially does the same thing but deeper into the inheritance code such that it only affects the attislocal attribute in pg_attribute. Also extend the external_tables ICW suite with a test covering this path.
danielgustafsson
force-pushed
the
exttable_inherit_att
branch
from
47e5f46
to
e521777
Compare
|
Closing as it has been bitrotting a bit too much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External tables doesn't support attribute inheritance, and while there is no syntax to trick plain inheritance into happening it was possible to get inherited attributes by injecting an external table into a partition hierarchy via partition exchange. Commit fcdd853 attempted to fix this but was erroneous and subsequently reverted with 7cfaed3. The pg_dump portion of the original patch was however not reverted and wasn't affecting the issue at hand.
The problem with that commit was that it broke off the inheritance chain too early, the partition still need inheritance to become part of the hierarchy. This commit essentially does the same thing but deeper into the inheritance code path such that it only affects the attislocal attribute in pg_attribute. There was discussion on gpdb-dev covering this.
Also extend the external_tables ICW suite with a test covering this path.