New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.docker.md: do not source old gcc compiler #5661

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@mdojo

mdojo commented Sep 3, 2018

Looks like the gcc compiler bundled in /opt/gcc_env.sh is now too old to compile gpdb (C++11x support is now necessary in the latest code). Remove that sourcing to instead use the gcc bundled with the pivotaldata/centos-gpdb-dev:7 image, which is new enough.

On our Macbook Pro, we were able to configure, build, and install gpdb, as well as run some simple queries on a gpdemo cluster.

Co-authored-by: Masashi Dojo i39526md@gmail.com
Co-authored-by: Amil Khanzada amilkh@gmail.com

README.docker.md: do not source old gcc compiler
Looks like the gcc compiler bundled in /opt/gcc_env.sh is now too old to compile gpdb (C++11x support is now necessary in the latest code). Remove that sourcing to instead use the gcc bundled with the pivotaldata/centos-gpdb-dev:7 image, which is new enough.

On our Macbook Pro, we were able to configure, build, and install gpdb, as well as run some simple queries on a gpdemo cluster.

Co-authored-by: Masashi Dojo <i39526md@gmail.com>
Co-authored-by: Amil Khanzada <amilkh@gmail.com>
@pivotal-issuemaster

This comment has been minimized.

Show comment
Hide comment
@pivotal-issuemaster

pivotal-issuemaster Sep 3, 2018

@mdojo Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-issuemaster commented Sep 3, 2018

@mdojo Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster

This comment has been minimized.

Show comment
Hide comment
@pivotal-issuemaster

pivotal-issuemaster commented Sep 3, 2018

@mdojo Thank you for signing the Contributor License Agreement!

@amilkh

This comment has been minimized.

Show comment
Hide comment
Contributor

amilkh commented Sep 3, 2018

@amilkh

This comment has been minimized.

Show comment
Hide comment
@amilkh

amilkh Sep 3, 2018

Contributor

@jvigil-pivotal @tyacovone can you please take a look?
Also, perhaps the pivotaldata/centos-gpdb-dev:7 image should have the /opt/gcc stuff removed if it is outdated.

Contributor

amilkh commented Sep 3, 2018

@jvigil-pivotal @tyacovone can you please take a look?
Also, perhaps the pivotaldata/centos-gpdb-dev:7 image should have the /opt/gcc stuff removed if it is outdated.

@d

This comment has been minimized.

Show comment
Hide comment
@d

d Sep 3, 2018

Member

It's unclear what problem you're solving. I checked the README this PR modifies, it's using a CentOS 7 based docker image, which means that /usr/bin/gcc is 4.8.5 . Correct? What's the "too old" version from /opt?

To be clear, I'm pretty tired of source /opt/gcc_env.sh, but it would be helpful in general for PR's and issues to make clear what problems they are solving

Member

d commented Sep 3, 2018

It's unclear what problem you're solving. I checked the README this PR modifies, it's using a CentOS 7 based docker image, which means that /usr/bin/gcc is 4.8.5 . Correct? What's the "too old" version from /opt?

To be clear, I'm pretty tired of source /opt/gcc_env.sh, but it would be helpful in general for PR's and issues to make clear what problems they are solving

@pivotal-ning-yu

This comment has been minimized.

Show comment
Hide comment
@pivotal-ning-yu

pivotal-ning-yu Sep 4, 2018

Member

@mdojo , just guess, are you executing something like sudo make or sudo make install? If so you are actually making with the system gcc instead of the opt one.

Member

pivotal-ning-yu commented Sep 4, 2018

@mdojo , just guess, are you executing something like sudo make or sudo make install? If so you are actually making with the system gcc instead of the opt one.

@amilkh

This comment has been minimized.

Show comment
Hide comment
@amilkh

amilkh Sep 4, 2018

Contributor

Thanks guys!

@d
We got an issue that after source /opt/gcc_env.sh, configure complained that the compiler must support C++11x. Upon inspection, we found that the gcc version bundled with /opt/gcc_env.sh was older than the system version. Sorry forgot to copy/paste the exact error.

@pivotal-ning-yu we got the error when doing configure. sorry to be unclear.

Contributor

amilkh commented Sep 4, 2018

Thanks guys!

@d
We got an issue that after source /opt/gcc_env.sh, configure complained that the compiler must support C++11x. Upon inspection, we found that the gcc version bundled with /opt/gcc_env.sh was older than the system version. Sorry forgot to copy/paste the exact error.

@pivotal-ning-yu we got the error when doing configure. sorry to be unclear.

@danielgustafsson

This comment has been minimized.

Show comment
Hide comment
@danielgustafsson

danielgustafsson Sep 7, 2018

Member

Looking at this from the other way, I'm not sure which problem we are solving with gcc_env.sh in the first place? Removing it from this README seems fairly sane but I might be missing something.

Member

danielgustafsson commented Sep 7, 2018

Looking at this from the other way, I'm not sure which problem we are solving with gcc_env.sh in the first place? Removing it from this README seems fairly sane but I might be missing something.

@amilkh

This comment has been minimized.

Show comment
Hide comment
@amilkh

amilkh Sep 7, 2018

Contributor
Contributor

amilkh commented Sep 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment