GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub?
to your account
The GPDB GUC optimizer_join_order_threshold (Orca CHint param m_ulJoinOrderDPLimit, btw, which is really bad, inconsistent naming) is only valid when its value is less than GPOPT_DP_JOIN_ORDERING_SIZE_THRESHOLD (10). The orca config param is overrode by https://github.com/greenplum-db/gporca/blame/master/libgpopt/src/xforms/CJoinOrderDP.cpp#L1059
We already have GPDB GUC optimizer_join_order_threshold to control the maximum
number of relations that we can do join reordering. The macro being removed
here is redundant.
Fixes issue greenplum-db#268
we should set the max value of optimizer_join_order_threshold to 10/12 after removing this macro. It will be then completely controlled by the GUC which is tunable then a hardcoded macro..
PR greenplum-db/gpdb#4046, #276
fixed by commit: 0171e2b