Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orca GUC optimizer_join_order_threshold doesn't take effect #268

Closed
hsyuan opened this issue Nov 25, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@hsyuan
Copy link
Contributor

commented Nov 25, 2017

The GPDB GUC optimizer_join_order_threshold (Orca CHint param m_ulJoinOrderDPLimit, btw, which is really bad, inconsistent naming) is only valid when its value is less than GPOPT_DP_JOIN_ORDERING_SIZE_THRESHOLD (10). The orca config param is overrode by https://github.com/greenplum-db/gporca/blame/master/libgpopt/src/xforms/CJoinOrderDP.cpp#L1059

hsyuan added a commit to hsyuan/gporca that referenced this issue Dec 1, 2017

Remove GPOPT_DP_JOIN_ORDERING_SIZE_THRESHOLD
We already have GPDB GUC optimizer_join_order_threshold to control the maximum
number of relations that we can do join reordering. The macro being removed
here is redundant.

Fixes issue greenplum-db#268
@bhuvnesh2703

This comment has been minimized.

Copy link
Member

commented Dec 4, 2017

we should set the max value of optimizer_join_order_threshold to 10/12 after removing this macro. It will be then completely controlled by the GUC which is tunable then a hardcoded macro..

@bhuvnesh2703

This comment has been minimized.

Copy link
Member

commented Dec 5, 2017

@hsyuan

This comment has been minimized.

Copy link
Contributor Author

commented Dec 16, 2017

fixed by commit: 0171e2b

@hsyuan hsyuan closed this Dec 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.