Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand string types for heterogeneous lookups #15

Merged
merged 1 commit into from Jul 10, 2019

Conversation

@fcharlie
Copy link
Contributor

commented Jul 10, 2019

In Windows, it's almost impossible to avoid using wchar_t, so
heterogeneous lookups that support std::wstring/std::wstring_view
are pretty good.

Expand string types for heterogeneous lookups
In Windows, it's almost impossible to avoid using wchar_t, so
heterogeneous lookups that support std::wstring/std::wstring_view
are pretty good.
@greg7mdp
Copy link
Owner

left a comment

Thanks, looks great.

@greg7mdp greg7mdp merged commit a55b53f into greg7mdp:master Jul 10, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@greg7mdp

This comment has been minimized.

Copy link
Owner

commented Jul 10, 2019

@fcharlie I have removed some code that your new change made redundant. I don't think it will break anything, but if it does please let me know.

@fcharlie

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

@greg7mdp Very good! I am very glad that you can merge this PR. Deleting the duplicate code does not seem to have any problems at present. I originally wanted to do this, but I am worried about affecting the original code.

fcharlie added a commit to fcharlie/bela that referenced this pull request Jul 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.