This repository has been archived by the owner on Nov 26, 2018. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
I was running into buggy behavior when trying to
compose()
tworeact-apollo
graphql()
HOCs, each with a followingwithProps()
ieTurned out that
graphql()
copies all static properties usinghoist-non-react-statics
, including the symbols thatrecompact
uses ("internally") to keep track of its state eg compactability, sowithProps()
was treatinggraphql()
as though it were anotherrecompact
HOC and bugginess ensuedIn this PR:
MAPPERS_INFO
andcompactable
symbols so that they can be passed to eghoist-non-react-statics
blacklistFrom my understanding of symbols, exporting the actual symbols used is necessary because there's no way to "recreate" them separately for use in a blacklist