Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up options #94

Closed
gregberge opened this issue May 12, 2018 · 3 comments
Closed

Clean up options #94

gregberge opened this issue May 12, 2018 · 3 comments
Milestone

Comments

@gregberge
Copy link
Owner

gregberge commented May 12, 2018

As we will support project configurations (#85), we will remove all Prettier options and keep only most used SVGO options.

  -V, --version                    CLI only
  -h, --help                       CLI only
  --ext <ext>                      Keep
  --icon                           Keep
  --ids                            Remove
  --jsx-bracket-same-line          Remove
  --keep-useless-defs              Rename into "useless-defs"
  --native                         Keep
  --no-bracket-spacing             Remove
  --no-dimensions                  Keep
  --no-expand-props                Keep
  --no-prettier                    Keep
  --no-semi                        Remove
  --no-svgo                        Keep
  --no-title                       Keep
  --no-view-box                    Keep
  -d, --out-dir <dirname>          Keep
  -p, --precision <value>          Keep
  --ref                            Keep
  --replace-attr-value [old=new]   Keep
  --single-quote                   Remove
  --tab-width <value>              Remove
  --template <file>                Keep
  --trailing-comma <none|es5|all>  Remove
  --use-tabs                       Remove

We will also add support for "--svgo-config" and "--prettier-config" to be able to specify custom configuration to use for these two plugins.

@loliver
Copy link

loliver commented Jun 12, 2018

The current implementation of --single-quote doesn't seem to replace the double quotes within the svg code itself, will the new version from --prettier-config do that?

@gregberge
Copy link
Owner Author

v2 is published 🎉

@gregberge
Copy link
Owner Author

@loliver yes it should work with the new version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants