Regex change for CSS gene naming, made browscap optional and off by default #15

Merged
merged 4 commits into from Dec 28, 2012

Conversation

Projects
None yet
2 participants
@ddn
Contributor

ddn commented Dec 28, 2012

gene naming for HTML elements uses only class immediately name to left of v + variant

@gregdingle

This comment has been minimized.

Show comment Hide comment
@gregdingle

gregdingle Dec 28, 2012

does this actually work? it looks like you just copied the JS var name into the line

does this actually work? it looks like you just copied the JS var name into the line

@gregdingle

This comment has been minimized.

Show comment Hide comment
@gregdingle

gregdingle Dec 28, 2012

Owner

It doesn't look like 2b3056b will work. Feel free to disable browscap on the server only. Don't worry about the client JS.

Owner

gregdingle commented Dec 28, 2012

It doesn't look like 2b3056b will work. Feel free to disable browscap on the server only. Don't worry about the client JS.

@ddn

This comment has been minimized.

Show comment Hide comment
@ddn

ddn Dec 28, 2012

Contributor

Uh, yeah, my bad. I don't know what I was thinking there.

Contributor

ddn commented Dec 28, 2012

Uh, yeah, my bad. I don't know what I was thinking there.

@ddn

This comment has been minimized.

Show comment Hide comment
@ddn

ddn Dec 28, 2012

Contributor

Sorry about that. Should be correct now, tested it locally.

Contributor

ddn commented Dec 28, 2012

Sorry about that. Should be correct now, tested it locally.

@ghost ghost assigned gregdingle Dec 28, 2012

gregdingle added a commit that referenced this pull request Dec 28, 2012

Merge pull request #15 from ddn/master
Regex change for CSS gene naming, made browscap optional and off by default

@gregdingle gregdingle merged commit 89c739a into gregdingle:master Dec 28, 2012

@gregdingle

This comment has been minimized.

Show comment Hide comment
@gregdingle

gregdingle Dec 28, 2012

Owner

Awesome!

Owner

gregdingle commented Dec 28, 2012

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment