Color support for bti #3

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
2 participants
@sunng87

sunng87 commented Oct 30, 2010

I made some changes on bti :)

  • add colors.h and colors.c, which contains code support for bti
  • add a new option '--auto-color' to toggle color support (in bti.c)
  • essential changes on Makefile.am
@gregkh

This comment has been minimized.

Show comment Hide comment
@gregkh

gregkh Nov 1, 2010

Owner

Thanks, but I do have some very basic issues.

The headers of your new files don't need to have all the copyright lines for everyone else, it would
only be your copyright, not mine and others as we didn't write that code, you did.

Also, please run your changes through the checkpatch.pl tool. the coding style has a few basic
issues.

If you clean those up, I'll be glad to pull the changes. I think overall you are going to have to move
to using libncurses, but for now the hard-coded bash color strings will suffice :)

thanks again for doing this work.

Owner

gregkh commented Nov 1, 2010

Thanks, but I do have some very basic issues.

The headers of your new files don't need to have all the copyright lines for everyone else, it would
only be your copyright, not mine and others as we didn't write that code, you did.

Also, please run your changes through the checkpatch.pl tool. the coding style has a few basic
issues.

If you clean those up, I'll be glad to pull the changes. I think overall you are going to have to move
to using libncurses, but for now the hard-coded bash color strings will suffice :)

thanks again for doing this work.

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment