Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Newer
Older
100644 49 lines (43 sloc) 2.33 kb
1df7b9d @gregkh notes update
authored
1 Ways to piss off a maintainer with patches you send them:
2
93b6dde @gregkh added notes to start with
authored
3 - html patch
1df7b9d @gregkh notes update
authored
4 - other patch email client issues (outlook, line-wrapping, mime, base64,
5 wierd extra spaces, tabs to spaces, etc.)
93b6dde @gregkh added notes to start with
authored
6 - patch does not apply
7 - patch does not build
8 - multiple patches with no ordering indicated
9 - patch made against unknown tree
10 - patch made against old kernel tree
11 - ask me to pull random git trees with no description of what is in them
12 - multi-patch series that breaks the build half way through the series
2917949 @gregkh Merge branch 'master' of github.com:gregkh/presentation-linux-maintainer
authored
13 - patches that blindly do checkpatch cleanups without realizing what
14 they are fixing
0249eb8 @gregkh notes update
authored
15 - patches that do more than one thing in the patch
2917949 @gregkh Merge branch 'master' of github.com:gregkh/presentation-linux-maintainer
authored
16 - fixes for compiler warnings that are due to old versions of gcc not
17 being smart (hint, upgrade your version of gcc)
18
93b6dde @gregkh added notes to start with
authored
19
f13a30c @gregkh More notes updates.
authored
20 (from my long-running series of how to piss off a maintainer)
2917949 @gregkh Merge branch 'master' of github.com:gregkh/presentation-linux-maintainer
authored
21 - sent patches to a different maintainer to try to route around you
22 (luckily, doesn't happen much anymore)
f13a30c @gregkh More notes updates.
authored
23 - send patches with wrong 'offset' requiring them to be edited by hand
24 - ignore coding style issues
2917949 @gregkh Merge branch 'master' of github.com:gregkh/presentation-linux-maintainer
authored
25 - send patches that depend on others to work or apply properly, yet
26 never mention this
f13a30c @gregkh More notes updates.
authored
27 - patches add new compiler warnings
28 - patches that oops when run, and were obviously not tested
2917949 @gregkh Merge branch 'master' of github.com:gregkh/presentation-linux-maintainer
authored
29 - paper over kernel warning messages by providing empty callback
30 functions (the kernel was making those warnings for a good reason, are
31 you smarter than the kernel? Really?)
f13a30c @gregkh More notes updates.
authored
32 - description of patch is opposite of what the patch actually did.
33 - multiple patches sent with exact same subject
34 - patches to clean up coding style issues that add new coding style warnings
2917949 @gregkh Merge branch 'master' of github.com:gregkh/presentation-linux-maintainer
authored
35 - patches asked for review, yet obviously never even run through our
36 automated review tools
37 - constant emails asking why you haven't applied their 117-patch series
38 they sent out yesterday. Emails sent in html format and not to the
39 mailing list
40 - private emails not sent to mailing lists
7b28a52 @gregkh stable patch complaints
authored
41
42
43 Stable patch specific review rants:
44 - patches sent with the wrong upstream git commit id in them.
45 - patches that differ in major ways from the upstream patch without saying that they are different
46 - patches sent with no information on what stable kernel they should be applied to
47 - patches sent with no git commit id
48 - patches that obviously do not meet the stable_kernel_rules.txt rules (spelling fixes for comments? You have got to be kidding me...)
Something went wrong with that request. Please try again.