Merged
Conversation
The switch from hash tables to arrays + linear lookups created a bug -- `names_genericstrtable` uses two variables (`h` and `t`) inconsistently in a loop, causing it to always return `NULL`, except for the first element in the array table. This in turn causes everything (except "Usage Page") in the HID descriptors to be `(null)` instead of the right string. Signed-off-by: Waffle Lapkin <waffle.lapkin@gmail.com>
94c0139 to
d03ed80
Compare
Owner
|
thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The switch from hash tables to arrays + linear lookups in #202 (cc @evelikov) created a bug --
names_genericstrtableuses two variables (handt) inconsistently in a loop, causing it to always returnNULL, except for the first element in the array table.This in turn causes everything (except "Usage Page") in the HID descriptors to be
(null)instead of the right string.I'm a bit surprised that this hasn't been caught by tests...
For comparison here is a snippet from
lsusb -vwithout this patch:And with this patch