The test suite that tests the tests (...yeah) fails #46

Closed
Matt-Deacalion opened this Issue Mar 11, 2013 · 4 comments

Comments

Projects
None yet
2 participants
Contributor

Matt-Deacalion commented Mar 11, 2013

If I run the _“runner_tests.py” (both Python2 and Python3) it fails on 5 tests.

  • test_that_end_report_displays_something
  • test_that_end_report_should_have_something_zenlike_on_it
  • test_that_end_report_shows_student_progress
  • test_that_end_report_shows_the_failure_report
  • test_filter_all_lessons_will_discover_test_classes_if_none_have_been_discovered_yet
Owner

gregmalcolm commented Apr 28, 2013

Thanks for the head's up. About to take a look

Owner

gregmalcolm commented Apr 28, 2013

Confession time: These tests are abysmal! :)

Aside from being a Python newbie at the time I wrote them, I was also relatively new to TDD. Looking back at them, there was too much reliance on mocks and too much testing of internal details. While I think I'd have a valid case of 86ing the whole lot of them, for now I have just ditched the worse offenders. And oh look- the tests magically pass now!

On another note, these tests were probably broken for ages. Think I might have a go at linking these tests up with Travis-CI to avoid this reoccurring...

Contributor

Matt-Deacalion commented Apr 29, 2013

Haha, nice and frank reponse! :-)

Owner

gregmalcolm commented Apr 29, 2013

... and Travisified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment