floppy forms should display the label_suffix set by user #148

Closed
subramanyamVemu opened this Issue Apr 15, 2015 · 6 comments

Projects

None yet

2 participants

@subramanyamVemu

If the form is instantiated with label_suffix, then floppy forms should display the same

Right now it always display ":"

Thanks
Subramanyam

@gregmuellegger
Owner

Yes, I absolutely agree. That should be a fairly small change in the templates/floppyforms/rows/* templates. However we would need at least a small bit of testing for this.

Would you like to contribute to make this happen? I'm happy to review and merge any pull requests or help out if you have questions about how to get started.

@subramanyamVemu

Sure I will go through the code over the weekend

Thanks
Subramanyam

@gregmuellegger
Owner

Super! Feel free to ask anything if you get stuck somewhere.

@subramanyamVemu

Gone through the code but a little stuck on the how to set the label_suffix as the BaseForm attribute

Also in 1.8 even the form fields can have a different label_suffix than the form itself

@gregmuellegger
Owner

Sorry, I forgot to respond to your questions :(

I implemented the feature now as an apology. You can find support for label_suffix (in forms and fields) in master for the builtin layouts.

Does it work for you now as expected?

@gregmuellegger
Owner

I just release django-floppyforms 1.5.0 which includes the changes for this ticket. Happy coding.

@gregmuellegger gregmuellegger added this to the 1.5 Release milestone Jul 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment