New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

floppy forms should display the label_suffix set by user #148

Closed
subramanyamVemu opened this Issue Apr 15, 2015 · 6 comments

Comments

Projects
None yet
2 participants
@subramanyamVemu

subramanyamVemu commented Apr 15, 2015

If the form is instantiated with label_suffix, then floppy forms should display the same

Right now it always display ":"

Thanks
Subramanyam

@gregmuellegger

This comment has been minimized.

Owner

gregmuellegger commented Apr 16, 2015

Yes, I absolutely agree. That should be a fairly small change in the templates/floppyforms/rows/* templates. However we would need at least a small bit of testing for this.

Would you like to contribute to make this happen? I'm happy to review and merge any pull requests or help out if you have questions about how to get started.

@subramanyamVemu

This comment has been minimized.

subramanyamVemu commented Apr 16, 2015

Sure I will go through the code over the weekend

Thanks
Subramanyam

@gregmuellegger

This comment has been minimized.

Owner

gregmuellegger commented Apr 17, 2015

Super! Feel free to ask anything if you get stuck somewhere.

@subramanyamVemu

This comment has been minimized.

subramanyamVemu commented Apr 19, 2015

Gone through the code but a little stuck on the how to set the label_suffix as the BaseForm attribute

Also in 1.8 even the form fields can have a different label_suffix than the form itself

@gregmuellegger

This comment has been minimized.

Owner

gregmuellegger commented May 21, 2015

Sorry, I forgot to respond to your questions :(

I implemented the feature now as an apology. You can find support for label_suffix (in forms and fields) in master for the builtin layouts.

Does it work for you now as expected?

@gregmuellegger

This comment has been minimized.

Owner

gregmuellegger commented Jul 17, 2015

I just release django-floppyforms 1.5.0 which includes the changes for this ticket. Happy coding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment