decimalfield should specify step=any #70

Closed
puterleat opened this Issue Jun 5, 2013 · 9 comments

Projects

None yet

4 participants

@puterleat

To avoid a validation error in chrome when entering decimals, the DecimalField template should specify

<input type="number" step="any" />

See: http://blog.isotoma.com/2012/03/html5-input-typenumber-and-decimalsfloats-in-chrome/

What I have done so far is this:

Added this to input.html:

{% if attrs.decimal %}step="any"{% endif %}

And created a new widget like this:

class DecimalInput(floppyforms.widgets.NumberInput):
    def __init__(self, *args, **kwargs):
        kwargs['attrs'] = {'decimal':True}
        super(DecimalWidget, self).__init__(*args, **kwargs)
@caacree
Contributor
caacree commented Apr 30, 2015

Not sure why this hasn't been implemented, I just ran into it as well. It's an easy fix, but should definitely be implemented into the field.

Instead of step="any", set it to be based on the number of decimal places. ie. step=".01" for decimal places=2 on the field, etc.

@gregmuellegger
Owner

Yep that's a great idea! I think that ticket just slipped through our attention.
I would be great to have this in the project. Would you like to implement that in a pull request?

@caacree
Contributor
caacree commented Apr 30, 2015

I've never contributed to a project before, but I'll give it a shot. Give me a few hours and I'll be back to work it out.

@gregmuellegger
Owner

Great that you want to give it a shot! Feel free to ask any question if you can't get along.
A good place to start is usually to write a failing test. Because then you have the confidence that the patch you are developing will do exactly what you want.

@marcoala

Stepped into this one as well, @caacree are you still working on this? I could try to write a patch for it

@gregmuellegger
Owner

@marcoala Sure, go ahead :) Cheers for stepping up.

@caacree
Contributor
caacree commented May 21, 2015

Sorry guys, totally forgot about this until I saw it in my email this morning. Honestly slipped my mind.

Just submitted the pull request.

@caacree
Contributor
caacree commented Jun 2, 2015

Hey Greg, sorry about that the first time around. Let me know if the tests pass now (not sure if there's a way I can see TravisCI stuff inside Github or I need it installed myself?).

Thanks.

@gregmuellegger
Owner

I just release django-floppyforms 1.5.0 which includes the changes for this ticket. Happy coding.

@gregmuellegger gregmuellegger added this to the 1.5 Release milestone Jul 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment