New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Django 1.9 #160

Merged
merged 5 commits into from Sep 28, 2015

Conversation

Projects
None yet
3 participants
@jonashaag
Contributor

jonashaag commented Sep 21, 2015

No description provided.

@@ -17,6 +18,7 @@ deps =
16: Django >= 1.6, < 1.7
17: Django >= 1.7, < 1.8
18: Django >= 1.8, < 1.9
19: https://github.com/django/django/tarball/master

This comment has been minimized.

@gregmuellegger

gregmuellegger Sep 22, 2015

Owner

We should add the Django 1.9 tests to the .travis.yml file as well to make sure that the tests also run in CI.

except ImportError:
# Django >= 1.9
from django.utils.datastructures import MultiValueDict
MULTIVALUE_DICT_TYPES = (MultiValueDict,)

This comment has been minimized.

@gregmuellegger

gregmuellegger Sep 22, 2015

Owner

I like to keep logic that forks on different Django versions in a compat.py file. We should stick this try/except in this file: https://github.com/gregmuellegger/django-floppyforms/blob/master/floppyforms/compat.py

'GenericIPAddressField', 'TypedChoiceField', 'FilePathField',
'TypedMultipleChoiceField', 'ComboField', 'MultiValueField',
'SplitDateTimeField',
)
if django.VERSION < (1, 9):

This comment has been minimized.

@gregmuellegger

gregmuellegger Sep 22, 2015

Owner

I would move this down to the class IPAddressField definition to keep the logic for the field together. Otherwise we might forget removing statement once we drop Django 1.8 support.

This comment has been minimized.

@jonashaag

jonashaag Sep 23, 2015

Contributor

I disagree: I'd rather keep all of the code related to __all__ in one place

This comment has been minimized.

@gregmuellegger

gregmuellegger Sep 24, 2015

Owner

Could live with it :)

@gregmuellegger

This comment has been minimized.

Owner

gregmuellegger commented Sep 22, 2015

Hi! Awesome to propose this pull request and thanks for the work. I have commented in a few place in-line. Would you be able to make those changes, I'm happy to merge after that.

@gregmuellegger

This comment has been minimized.

Owner

gregmuellegger commented Sep 24, 2015

The Python 3.2 tests are failing on TravisCI. But I'm happy to drop 3.2 support so don't worry about these. However, the flake8 check is failing as well. Would you like to tackle this? https://travis-ci.org/gregmuellegger/django-floppyforms/jobs/81732728

If not it's fine it should be minor enough that I will be able to add it after a merge.

@gregmuellegger gregmuellegger merged commit b4592ef into gregmuellegger:master Sep 28, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@gregmuellegger

This comment has been minimized.

Owner

gregmuellegger commented Sep 28, 2015

Awesome work! Thanks so much for the PR.

@stefanw

This comment has been minimized.

stefanw commented Dec 2, 2015

Thanks everyone! Django 1.9 just got released, so if you have the time, please push a release to pypi.

@gregmuellegger

This comment has been minimized.

Owner

gregmuellegger commented Dec 3, 2015

@stefanw

This comment has been minimized.

stefanw commented Dec 4, 2015

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment