Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1826 remove @mui/styles from project #1862

Merged
merged 6 commits into from Feb 20, 2022

Conversation

Fullbusters
Copy link
Contributor

@Fullbusters Fullbusters commented Feb 16, 2022

remove @mui/styles according to #1826

@Fullbusters
Copy link
Contributor Author

@zxhmike @wdh2100 @ashfaqnisar @gregnb please take a look into this PR

@ashfaqnisar
Copy link
Contributor

ashfaqnisar commented Feb 17, 2022

Hey @Fullbusters, Great Work Buddy. I have connected this PR to my project and everything worked great. Didn't find any visible issues with the component. Will push the fixes if i found any later on. Just had some lint issues, which I pushed a Fullbusters#1 to you're repo.

@ashfaqnisar
Copy link
Contributor

ashfaqnisar commented Feb 17, 2022

I think we also have to update the readme, so the users should install tss-react along with the material ui packages

@Fullbusters
Copy link
Contributor Author

@ashfaqnisar thanks, already update current pull request with your changes, thanks for fast review
please notify if I need do something fo merge it

@ashfaqnisar
Copy link
Contributor

Hey @wdh2100, this looks great, can you go ahead merge this and we can push new changes if there are any issues in the future.

@liamlows
Copy link

Super excited to see this update, finally @mui/styles can go away haha

@wdh2100
Copy link
Collaborator

wdh2100 commented Feb 20, 2022

@Fullbusters

thanks 😄

It will have to be completely replaced later.
In my opinion, adding dependencies would be a burden later.

ref : https://mui.com/guides/migration-v4/#migrate-from-jss

@wdh2100
Copy link
Collaborator

wdh2100 commented Feb 20, 2022

I will release a new version soon

@wdh2100 wdh2100 merged commit d276d6a into gregnb:master Feb 20, 2022
federi95 pushed a commit to federi95/mui-datatables that referenced this pull request Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants