Skip to content

gregorriegler/order-dispatch-refactoring-kata

 
 

Folders and files

NameName
Last commit message
Last commit date

Latest commit

 

History

55 Commits
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 

Repository files navigation

Order Dispatch Refactoring Kata

A legacy refactor kata, focused on the violation of the Tell Don't Ask principle and the Anemic Domain Model.

Instructions

Here you find a simple order flow application. It's able to create orders, do some calculation (totals and taxes), and manage them (approval/reject and shipment).

The old development team did not find the time to build a proper domain model but instead preferred to use a procedural style, building this anemic domain model. Fortunately, they did at least take the time to write unit tests for the code.

Your new CTO, after many bugs caused by this application, asked you to refactor this code to make it more maintainable and reliable.

What to focus on

As the title of the kata says, of course, the tell don't ask principle. You should be able to remove all the setters moving the behavior into the domain objects.

But don't stop there.

If you can remove some test cases because they don't make sense anymore (eg: you cannot compile the code to do the wrong thing) feel free to do it!

Credit

The Kata was originally authored by @racingDeveloper
Typescript and Python3 versions by mapu77
PHP version by Archel
CSharp version by raullorca
Kotlin and Java+Lombok versions by @gregor_riegler

About

A legacy refactor kata, focused on the violation of the tell don't ask principle and anemic domain model

Resources

License

Stars

Watchers

Forks

Releases

No releases published

Packages

No packages published

Languages

  • Java 27.3%
  • PHP 18.6%
  • C# 17.3%
  • Python 13.1%
  • TypeScript 12.6%
  • Kotlin 11.1%