Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix datetime format in card list filter. #260

Merged
merged 2 commits into from Oct 18, 2018

Conversation

@zodchiy
Copy link
Contributor

zodchiy commented Oct 17, 2018

Fix datetime format in card list filter to ISO.

Fix datetime format in card list filter to ISO.
@gregsdennis

This comment has been minimized.

Copy link
Owner

gregsdennis commented Oct 17, 2018

This one's good. I think I somehow expected the serializer to format it correctly, but this is in a query parameter, so the serializer never sees it. Nice catch.

I'll open a branch for a new version and merge everything into that so that I can merge into master all at once.

@gregsdennis gregsdennis changed the base branch from master to release/3.4.1 Oct 17, 2018
@gregsdennis gregsdennis mentioned this pull request Oct 17, 2018
Copy link
Owner

gregsdennis left a comment

Please remove the extra ; from the ends of the lines.

@zodchiy

This comment has been minimized.

Copy link
Contributor Author

zodchiy commented Oct 18, 2018

ok, i fix this.

Copy link
Owner

gregsdennis left a comment

Thanks

@gregsdennis gregsdennis merged commit 9fbd80f into gregsdennis:release/3.4.1 Oct 18, 2018
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.