New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for company-backend doc-buffer #142

Merged
merged 1 commit into from Dec 3, 2017

Conversation

Projects
None yet
2 participants
@cpbotha
Contributor

cpbotha commented Nov 23, 2017

Whilst going through company-ob-ipython completions, you can request
documentation using f1 or C-h. ob-ipython will inspect the completion
candidate and show the docs using the ob-ipython-inspect
functionality.

I had to factor out the ob-ipython--inspect-code defun in order to be able
to call it from the doc-buffer handling. I also added comments and docs here
and there. Existing functionality remains unchanged.

Add support for company-backend doc-buffer
Whilst going through company-ob-ipython completions, you can request
documentation using f1 or C-h. ob-ipython will inspect the completion
candidate and show the docs using the ob-ipython-inspect
functionality.
@cpbotha

This comment has been minimized.

Show comment
Hide comment
@cpbotha

cpbotha Nov 23, 2017

Contributor

image

Contributor

cpbotha commented Nov 23, 2017

image

@gregsexton

This comment has been minimized.

Show comment
Hide comment
@gregsexton

gregsexton Nov 26, 2017

Owner

This is very cool. Thanks for sending. I'll be bored on a plane today so will look to merge then. :)

Owner

gregsexton commented Nov 26, 2017

This is very cool. Thanks for sending. I'll be bored on a plane today so will look to merge then. :)

@cpbotha

This comment has been minimized.

Show comment
Hide comment
@cpbotha

cpbotha Dec 1, 2017

Contributor

@gregsexton Please let me know if you need any more inputs to be able to merge this.

It's possible that we want to make more PRs in the future.

Contributor

cpbotha commented Dec 1, 2017

@gregsexton Please let me know if you need any more inputs to be able to merge this.

It's possible that we want to make more PRs in the future.

@gregsexton gregsexton merged commit e34c00d into gregsexton:master Dec 3, 2017

@gregsexton

This comment has been minimized.

Show comment
Hide comment
@gregsexton

gregsexton Dec 3, 2017

Owner

Sorry about this. I merged last week but forgot to push. :D

Owner

gregsexton commented Dec 3, 2017

Sorry about this. I merged last week but forgot to push. :D

@cpbotha

This comment has been minimized.

Show comment
Hide comment
@cpbotha

cpbotha Dec 4, 2017

Contributor

Great stuff, thank you for merging!

Contributor

cpbotha commented Dec 4, 2017

Great stuff, thank you for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment