Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

removed GHMenuCell dependency #2

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

crino commented Jul 26, 2012

extended uitableviewcell creation to GHSiderbarSearchViewControllerDelegate to remove GHMenuCell dependency

I really like the idea of allowing the delegate to create the cell.

I would make the method required, however, since mutableEntries could contain any sort of object and assuming it is an NSString, or any other type, is dangerous.

I'd also rename the delegate method to be clearer about what is going on. Something along the lines of:
- (UITableViewCell *)searchResultCellForEntry:(id)entry atIndexPath:(NSIndexPath *)indexPath inTableView:(UITableView *)tableView;

Owner

crino replied Jul 26, 2012

I just made the mod just to share the idea and i agree with your review.

I hope to contribute more on project ;)

crino commented Jul 27, 2012

;)

@crino crino closed this Jul 27, 2012

@ghost ghost assigned gresrun Sep 18, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment