-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve installation of dependencies #417
Merged
njtierney
merged 99 commits into
greta-dev:master
from
njtierney:njt-only-install-greta-deps
Jun 4, 2021
Merged
Improve installation of dependencies #417
njtierney
merged 99 commits into
greta-dev:master
from
njtierney:njt-only-install-greta-deps
Jun 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…after Python has already been initialized.
This will probably be skipped on CRAN but at the moment I need to test if the new config/reticulate option works properly
…as the latter retuns an object of class "package_version".
* Installs specific versions of tensorflow (1.14.0), tensorflow probability (0.7.0), and numpy (1.16.4)
* Establish new helper file that does conda_create and then establishes the right python version (3.7), and other python packages and versions to install
…f via conda create
add to automatic dependency installation steps; tidy up messaging
…ta_deps`, and update instructions on using `install_greta_deps`.
turn off reticulate's autoconfig when initialising python
Todo list:
|
…erney/greta into njt-only-install-greta-deps
…th current messages
njtierney
force-pushed
the
njt-only-install-greta-deps
branch
from
June 3, 2021 01:33
d884cc6
to
35c8b96
Compare
add 'depends.rds' to Rbuildignore to remove a note on github actions
4 tasks
…s in relation to the `install_greta_deps()` function.
Going to merge this as the only GH action that is breaking is some obscure fail where |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a new process for installing python dependencies, and a better user experience for dealing with this.
It addresses this by installing the needed python packages into a special "greta-env" conda environment. This can be thought of as similar to a docker container, or a
renv.lock
file. Our specified python dependencies are all put into this "greta-env" environment, which greta checks exists when loading up greta.An example of this new process is shown below:
Resolves #396