Fix issue with high CPU usage. #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid copying the incoming std::map on each call. Also, try to reduce the number of interactions overall once the map's object has been retrieved. This closes gridcoin-community#140 (for real).
|
Testing on windows now! Thanks for the awesome work. |
|
I do see some fairly high CPU usage (11%) even after this fix when the signing kicked in. I'll poke around to see where the rest of the cycles are used, but I suspect the scrypt is the culprit. |
gridcoin
added a commit
that referenced
this pull request
Dec 31, 2016
Gridcoin Research 3.5.8.4/MSI=41.9 Leisure Upgrade - Catch HTTP error on Diagnostics page - Add checkpoints up to 770000 - Remove unused functions (cryptolottery, options trading) - Merge in Denravonska #158 - CPU-Usage-Fix: This fix prevents GRC from copying memory structs and is designed to lower CPU usage
denravonska
pushed a commit
that referenced
this pull request
Apr 15, 2017
Gridcoin Research 3.5.8.4/MSI=41.9 Leisure Upgrade - Catch HTTP error on Diagnostics page - Add checkpoints up to 770000 - Remove unused functions (cryptolottery, options trading) - Merge in Denravonska #158 - CPU-Usage-Fix: This fix prevents GRC from copying memory structs and is designed to lower CPU usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid copying the incoming std::map on each call. Also, try to reduce the number of interactions overall once the map's object has been retrieved.
This closes #140 (for real).
On my Core2Duo this dropped the idle CPU usage from 50-60% to 0.7%.