From 27a6e64932f5e7ab2d7caaa8397fb634f712b6a5 Mon Sep 17 00:00:00 2001
From: ddurnev <ddurnev@griddynamics.com>
Date: Thu, 21 Mar 2013 17:42:40 +0400
Subject: [PATCH] [RJA-2014][fix]: Validation error message placement fixed
 Moved datetime picker settings init to app.js

---
 ui/src/main/resources/genesis/app/app.js         | 16 ++++++++++++++++
 .../app/modules/env_details/env_details.js       | 10 +---------
 2 files changed, 17 insertions(+), 9 deletions(-)

diff --git a/ui/src/main/resources/genesis/app/app.js b/ui/src/main/resources/genesis/app/app.js
index 4f6a3ab43..568dde9d7 100755
--- a/ui/src/main/resources/genesis/app/app.js
+++ b/ui/src/main/resources/genesis/app/app.js
@@ -217,6 +217,15 @@ function(genesis, routermodule, jQuery, Backbone, _, backend, status, Projects,
       } else {
         $(".logout-link").attr("href", logoutLink.href)
       }
+      // datetime picker settings customization:
+      var locale = app.currentConfiguration.locale;
+      $.timepicker.setDefaults({
+        controlType :"select",
+        showOn: "button", buttonText: "Select date & time",
+        buttonImage: "assets/img/date-picker.png", buttonImageOnly: true,
+        // TODO: provide timepicker localization file
+        timeFormat: locale == "en-US" ? "hh:mm tt" : "HH:mm"
+      });
     }
 
     $("#connection-error").ajaxError(function(event, jqXHR) {
@@ -271,4 +280,11 @@ function(genesis, routermodule, jQuery, Backbone, _, backend, status, Projects,
     }
   });
 
+  // fix validation error placement
+  $.validator.setDefaults({
+    errorPlacement: function(error, element) {
+      error.appendTo(element.parent());
+    }
+  });
+
 });
diff --git a/ui/src/main/resources/genesis/app/modules/env_details/env_details.js b/ui/src/main/resources/genesis/app/modules/env_details/env_details.js
index 63c9d7c99..932d0a0a8 100755
--- a/ui/src/main/resources/genesis/app/modules/env_details/env_details.js
+++ b/ui/src/main/resources/genesis/app/modules/env_details/env_details.js
@@ -612,7 +612,7 @@ function (genesis, backend, poller, status, EnvHistory, variablesmodule, gtempla
           } else {
             view.trigger("workflow-validation-errors");
             var validator = $('#workflow-parameters-form').validate();
-              validator.showErrors(json.variablesErrors);
+            validator.showErrors(json.variablesErrors);
           }
         }
       );
@@ -631,14 +631,6 @@ function (genesis, backend, poller, status, EnvHistory, variablesmodule, gtempla
         }));
 
         if(view.scheduling) {
-          var locale = genesis.app.currentConfiguration.locale;
-          $.timepicker.setDefaults({
-            controlType :"select",
-            showOn: "button", buttonText: "Select date & time",
-            buttonImage: "assets/img/date-picker.png", buttonImageOnly: true,
-            // TODO: provide timepicker localization file
-            timeFormat: locale == "en-US" ? "hh:mm tt" : "HH:mm"
-          });
           var date = new Date();
           date.setHours(0);
           date.setMinutes(0);