Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transformer-yaml): add transformer #133

Merged
merged 3 commits into from Jan 20, 2019

Conversation

Projects
None yet
2 participants
@mottox2
Copy link
Member

commented Jan 16, 2019

This PR add @gridsome/transformer-yaml plugin to gridsome.
This should close #131.

@hjvedvik

This comment has been minimized.

Copy link
Member

commented Jan 16, 2019

Thanks :) Should the parsed yaml data be used as fields to make them accessible as node.myField etc. instead?

@mottox2

This comment has been minimized.

Copy link
Member Author

commented Jan 16, 2019

Thanks. I fixed schema.
If yaml is object, we can access as node.myField, but if yaml is array, we can access as node.data.

@hjvedvik
Copy link
Member

left a comment

Just a few more changes :)

Show resolved Hide resolved packages/transformer-yaml/package.json Outdated
Show resolved Hide resolved packages/transformer-yaml/index.js Outdated
Show resolved Hide resolved packages/transformer-yaml/README.md Outdated
@mottox2

This comment has been minimized.

Copy link
Member Author

commented Jan 16, 2019

Thanks you for review. I fixed these comment.

@hjvedvik hjvedvik merged commit d9ade15 into gridsome:master Jan 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.