From 03b5fcc5d578017766ad4d595caadda4dedb49fc Mon Sep 17 00:00:00 2001
From: sBouzols <sylvain.bouzols@gmail.com>
Date: Thu, 27 Jun 2024 16:23:35 +0200
Subject: [PATCH 1/2] fix(): Warning: Failed prop type: Invalid prop `disabled`
 of type `object` supplied to `ForwardRef(FormControl2)`, expected `boolean`.

Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
---
 .../filter/explicit-naming/explicit-naming-filter-form.tsx    | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/components/filter/explicit-naming/explicit-naming-filter-form.tsx b/src/components/filter/explicit-naming/explicit-naming-filter-form.tsx
index 6b8bc8373..756464e52 100644
--- a/src/components/filter/explicit-naming/explicit-naming-filter-form.tsx
+++ b/src/components/filter/explicit-naming/explicit-naming-filter-form.tsx
@@ -241,7 +241,9 @@ const ExplicitNamingFilterForm: FunctionComponent<
                     Input={SelectInput}
                     name={FieldConstants.EQUIPMENT_TYPE}
                     options={Object.values(FILTER_EQUIPMENTS)}
-                    disabled={sourceFilterForExplicitNamingConversion}
+                    disabled={
+                        sourceFilterForExplicitNamingConversion !== undefined
+                    }
                     label={'equipmentType'}
                     shouldOpenPopup={openConfirmationPopup}
                     resetOnConfirmation={handleResetOnConfirmation}

From 7831d69fef62882c93b3b4f41fc08f43b9679c35 Mon Sep 17 00:00:00 2001
From: sBouzols <sylvain.bouzols@gmail.com>
Date: Wed, 18 Sep 2024 14:03:02 +0200
Subject: [PATCH 2/2] fix from review, prefer !! to convert object into boolean
 as other usage in code

Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
---
 .../filter/explicitNaming/ExplicitNamingFilterForm.tsx          | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/components/filter/explicitNaming/ExplicitNamingFilterForm.tsx b/src/components/filter/explicitNaming/ExplicitNamingFilterForm.tsx
index 45f6b0cee..ae8e2fa6c 100644
--- a/src/components/filter/explicitNaming/ExplicitNamingFilterForm.tsx
+++ b/src/components/filter/explicitNaming/ExplicitNamingFilterForm.tsx
@@ -218,7 +218,7 @@ function ExplicitNamingFilterForm({ sourceFilterForExplicitNamingConversion }: E
                     Input={SelectInput}
                     name={FieldConstants.EQUIPMENT_TYPE}
                     options={Object.values(FILTER_EQUIPMENTS)}
-                    disabled={sourceFilterForExplicitNamingConversion !== undefined}
+                    disabled={!!sourceFilterForExplicitNamingConversion}
                     label="equipmentType"
                     shouldOpenPopup={openConfirmationPopup}
                     resetOnConfirmation={handleResetOnConfirmation}