Skip to content

Only debug logging for exceptions #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 30, 2025
Merged

Only debug logging for exceptions #212

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc7275f
Only debug logging for exceptions
FranckLecuyer Sep 22, 2025
4c5087f
Remove useless check
FranckLecuyer Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 12 additions & 21 deletions src/main/java/org/gridsuite/directory/server/RestResponseEntityExceptionHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,27 +25,18 @@ public class RestResponseEntityExceptionHandler {

@ExceptionHandler(value = {DirectoryException.class})
protected ResponseEntity<Object> handleException(RuntimeException exception) {
if (LOGGER.isErrorEnabled()) {
LOGGER.error(exception.getMessage(), exception);
}
DirectoryException directoryException = (DirectoryException) exception;
switch (directoryException.getType()) {
case NOT_ALLOWED:
return ResponseEntity.status(HttpStatus.FORBIDDEN).body(NOT_ALLOWED);
case IS_DIRECTORY:
return ResponseEntity.status(HttpStatus.FORBIDDEN).body(IS_DIRECTORY);
case NOT_DIRECTORY:
return ResponseEntity.status(HttpStatus.FORBIDDEN).body(NOT_DIRECTORY);
case NOT_FOUND:
return ResponseEntity.status(HttpStatus.NOT_FOUND).body(NOT_FOUND);
case UNKNOWN_NOTIFICATION:
return ResponseEntity.status(HttpStatus.BAD_REQUEST).body(UNKNOWN_NOTIFICATION);
case NAME_ALREADY_EXISTS:
return ResponseEntity.status(HttpStatus.CONFLICT).body(directoryException.getMessage());
case MOVE_IN_DESCENDANT_NOT_ALLOWED:
return ResponseEntity.status(HttpStatus.FORBIDDEN).body(MOVE_IN_DESCENDANT_NOT_ALLOWED);
default:
return ResponseEntity.status(HttpStatus.INTERNAL_SERVER_ERROR).build();
}
LOGGER.debug(exception.getMessage(), exception);
return switch (directoryException.getType()) {
case NOT_ALLOWED -> ResponseEntity.status(HttpStatus.FORBIDDEN).body(NOT_ALLOWED);
case IS_DIRECTORY -> ResponseEntity.status(HttpStatus.FORBIDDEN).body(IS_DIRECTORY);
case NOT_DIRECTORY -> ResponseEntity.status(HttpStatus.FORBIDDEN).body(NOT_DIRECTORY);
case NOT_FOUND -> ResponseEntity.status(HttpStatus.NOT_FOUND).body(NOT_FOUND);
case UNKNOWN_NOTIFICATION -> ResponseEntity.status(HttpStatus.BAD_REQUEST).body(UNKNOWN_NOTIFICATION);
case NAME_ALREADY_EXISTS ->
ResponseEntity.status(HttpStatus.CONFLICT).body(directoryException.getMessage());
case MOVE_IN_DESCENDANT_NOT_ALLOWED ->
ResponseEntity.status(HttpStatus.FORBIDDEN).body(MOVE_IN_DESCENDANT_NOT_ALLOWED);
};
}
}