Add index on start_date and end_date columns in announcement table #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
TheMaskedTurtle
requested changes
Nov 3, 2025
Contributor
TheMaskedTurtle
left a comment
TheMaskedTurtle
left a comment
There was a problem hiding this comment.
Don't forget the annotation in the entity. Normally, you should put the annotion in the entity and then generate the changelog with liquibase.
| <databaseChangeLog xmlns="http://www.liquibase.org/xml/ns/dbchangelog" xmlns:ext="http://www.liquibase.org/xml/ns/dbchangelog-ext" xmlns:pro="http://www.liquibase.org/xml/ns/pro" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog-ext http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-ext.xsd http://www.liquibase.org/xml/ns/pro http://www.liquibase.org/xml/ns/pro/liquibase-pro-latest.xsd http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-latest.xsd"> | ||
| <changeSet author="lecuyerfra" id="create_start_date_index"> | ||
| <createIndex indexName="announcement_start_date_index" tableName="announcement"> | ||
| <column name="start_date"/> |
Contributor
There was a problem hiding this comment.
I think it's better to have only one index with both start_date and end_date as we query with both values everytime
Create only one index for both columns start_date and end_date Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
|
TheMaskedTurtle
approved these changes
Nov 3, 2025
FranckLecuyer
deleted the
add_index_on_announcement_start_and_end_date
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
In user-admin, there is a cron job running every 5 minutes, that checks if an announcement is present, and there is no index on start_date and end_date columns in the database, so a seqscan is always done.
So, adding index on these columns avoid using a seqscan ...