Skip to content

Add index on start_date and end_date columns in announcement table #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2025
Merged

Add index on start_date and end_date columns in announcement table #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc430e9
Add index on start_date and end_date columns in announcement table
FranckLecuyer Oct 31, 2025
2643cda
Add JPA annotation for the index creation on AnnouncementEntity
FranckLecuyer Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/gridsuite/useradmin/server/entity/AnnouncementEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
@Getter
@Setter
@Entity
@Table(name = "announcement")
@Table(name = "announcement", indexes = @Index(name = "start_end_date_index", columnList = "startDate, endDate"))
public class AnnouncementEntity {

@Id
Expand Down
9 changes: 9 additions & 0 deletions src/main/resources/db/changelog/changesets/changelog_20251031T110224Z.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<?xml version="1.1" encoding="UTF-8" standalone="no"?>
<databaseChangeLog xmlns="http://www.liquibase.org/xml/ns/dbchangelog" xmlns:ext="http://www.liquibase.org/xml/ns/dbchangelog-ext" xmlns:pro="http://www.liquibase.org/xml/ns/pro" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog-ext http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-ext.xsd http://www.liquibase.org/xml/ns/pro http://www.liquibase.org/xml/ns/pro/liquibase-pro-latest.xsd http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-latest.xsd">
<changeSet author="lecuyerfra (generated)" id="1762182222231-7">
<createIndex indexName="start_end_date_index" tableName="announcement">
<column name="start_date"/>
Copy link
Contributor

@TheMaskedTurtle TheMaskedTurtle Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to have only one index with both start_date and end_date as we query with both values everytime

Copy link
Contributor Author

@FranckLecuyer FranckLecuyer Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Done

<column name="end_date"/>
</createIndex>
</changeSet>
</databaseChangeLog>
3 changes: 3 additions & 0 deletions src/main/resources/db/changelog/db.changelog-master.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,6 @@ databaseChangeLog:
- include:
file: changesets/changelog_20250820T000000Z.xml
relativeToChangelogFile: true
- include:
file: changesets/changelog_20251031T110224Z.xml
relativeToChangelogFile: true