New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix skip count #94

Merged
merged 12 commits into from Apr 22, 2018

Conversation

Projects
None yet
3 participants
@yang-yangfeng
Contributor

yang-yangfeng commented Jan 5, 2018

Acceptor/exon/donor skips were not being counted correctly. Fixed logic to check for skipping and also tweaked the exon_skipped set keys (which were simply 'exon' since exon.name was being set to just 'exon')

@coveralls

This comment has been minimized.

coveralls commented Jan 7, 2018

Coverage Status

Coverage increased (+0.007%) to 89.694% when pulling 6612cf1 on fix_skip_count into 9c06227 on master.

@yang-yangfeng

This comment has been minimized.

Contributor

yang-yangfeng commented Jan 9, 2018

@gatoravi would you mind taking a look at these changes to see if they make sense?

@gatoravi

This comment has been minimized.

Contributor

gatoravi commented Jan 10, 2018

Looks good to me! +1

@yang-yangfeng

This comment has been minimized.

Contributor

yang-yangfeng commented Apr 21, 2018

note: addresses #61

@yang-yangfeng yang-yangfeng merged commit cacbb3b into master Apr 22, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.007%) to 89.694%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment