Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standard decompositions are NOT always pairwise #18

Closed
behdad opened this issue Oct 2, 2017 · 1 comment
Closed

Standard decompositions are NOT always pairwise #18

behdad opened this issue Oct 2, 2017 · 1 comment

Comments

@behdad
Copy link
Contributor

behdad commented Oct 2, 2017

Please revert 0613261. That is not true, and it breaks decomposition for U+212B ANGSTROM SIGN and possibly a few other characters. We've reverted that in HarfBuzz. Caught by HB's test-unicode.c
behdad added a commit to harfbuzz/harfbuzz that referenced this issue Oct 2, 2017
@behdad
[ucdn] Update to Unicode 10
0faa16a 
Update to commit c000ebf79c095a7d58cf90090bde5715592c4834
plus this bug-fix: grigorig/ucdn#18
grigorig added a commit that referenced this issue Oct 2, 2017
@grigorig
Revert "Simplify ucdn_decompose"
2db378b 
This reverts commit 0613261.

Fixes issue #18.
@grigorig
Copy link
Owner

grigorig commented Oct 2, 2017

Looks like I have some more work to do to improve UCDN's own tests. Thanks for thead heads-up!

@grigorig grigorig closed this as completed Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@behdad @grigorig