Skip to content

Commit

Permalink
Old variable definition not removed and was hiding function parameter…
Browse files Browse the repository at this point in the history
…. If

variable definition attained a non null value, code could also crash. In
worst case, if neither handler or filter specified, result would have been
value of PythonInterpPerDirective setting. The latter shouldn't in practice
occur but cater for it anyway. (MODPYTHON-103)
  • Loading branch information
grahamd committed May 9, 2006
1 parent bbf0458 commit 4ab94e5
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/mod_python.c
Expand Up @@ -1260,14 +1260,15 @@ static const char *select_interp_name(request_rec *req, conn_rec *con,
* global interpreter.
*/

py_handler *fh;

if (fh) {
s = fh->directory;
}
else if (hle) {
s = hle->directory;
}
else {
return NULL;
}

if (s && (s[0] == '\0'))
return NULL;
Expand Down

0 comments on commit 4ab94e5

Please sign in to comment.