Add user id middleware to form pages #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulfitz
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Thanks @georgegevoian !
For grist-desktop, we've been thinking of adding a test run in grist-core CI to check the effect changes will have on it. Adding grist-omnibus also would be neat. My vision I think is of something like the deployment tests. Not 100% sure it is practical. Alternative is the more usual of tests running in the other repos after they upgrade to latest grist-core, before a release.
hexaltation
pushed a commit
to hexaltation/grist-core
that referenced
this pull request
Jun 12, 2024
CamilleLegeron
pushed a commit
to incubateur-territoires/grist-core
that referenced
this pull request
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #966.
Tested locally with a default grist-omnibus instance.