New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow +2 nameserver entries for dns= boot option #4

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@lvdh
Copy link

lvdh commented Dec 14, 2014

Would this change be sufficient to allow more than two nameservers to be entered at live boot? (using the 'dns' boot option)

Apologies for my ignorance if more changes are necessary to solve this problem. Any pointers in the right direction are very welcome, I'm more than happy to learn.

For reference, this has been discussed in issue 1234: http://bts.grml.org/grml/issue1234

@lvdh

This comment has been minimized.

Copy link
Author

lvdh commented Dec 14, 2014

FYI, make test does not show any possible problems for the affected files;

[live-boot-grml]$ make test
Checking for syntax errors......................... done.
Checking for bashisms.........possible bashism in components/9990-aaa-fixme.sh line 13 (HOST(TYPE|NAME)=):
HOSTNAME="host"
.....possible bashism in components/9990-misc-helpers.sh line 624 (read with option other than -r):
                    read -s passphrase
possible bashism in components/9990-misc-helpers.sh line 1319 (ulimit):
            ( sysctl -w fs.file-max=391524 ; ulimit -HSn 16384
...possible bashism in components/9990-mount-iscsi.sh line 39 (echo -e):
            echo -ne $i\\r
....possible bashism in components/9990-networking.sh line 132 ($HOST(TYPE|NAME)):
        OLDHOSTNAME=${HOSTNAME}
possible bashism in components/9990-networking.sh line 136 ($HOST(TYPE|NAME)):
        [ -z ${HOSTNAME} ] && HOSTNAME=${OLDHOSTNAME}
possible bashism in components/9990-networking.sh line 136 (HOST(TYPE|NAME)=):
        [ -z ${HOSTNAME} ] && HOSTNAME=${OLDHOSTNAME}
.... done.
[live-boot-grml]$ 

@evgeni evgeni self-assigned this Aug 10, 2015

@evgeni

This comment has been minimized.

Copy link
Member

evgeni commented Aug 16, 2015

Thanks, marged in 5eb34d4

@evgeni evgeni closed this Aug 16, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment