Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORS headers not sent when authorization fails #861

Closed
berrnd opened this issue May 19, 2020 · 1 comment
Closed

CORS headers not sent when authorization fails #861

berrnd opened this issue May 19, 2020 · 1 comment
Labels
bug
Milestone
v3.0.0

Comments

@berrnd
Copy link
Member

berrnd commented May 19, 2020

Originally posted by @winterscar in #681 (comment)

The reason was because I was not authenticating (just to test the cors stuff), and the ApiAuthMiddleware doesn't serve cors tokens on failure.

So if you fail to auth (because you didn't provide/provided an invalid token, instead of getting an auth error, you'll get a cors one!
@berrnd berrnd added the bug label May 19, 2020
@berrnd berrnd mentioned this issue May 19, 2020
Closed
@berrnd berrnd added this to the v3.0.0 milestone Aug 18, 2020
Merged
@berrnd
Copy link
Member Author

berrnd commented Dec 19, 2020

Was fixed by #976.

@berrnd berrnd closed this as completed Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
v3.0.0
Development

No branches or pull requests
1 participant
@berrnd