Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer component does not animate in mobile #5236

Closed
brianbancroft opened this issue May 9, 2021 · 2 comments
Closed

Layer component does not animate in mobile #5236

brianbancroft opened this issue May 9, 2021 · 2 comments
Labels
bug issue that does not match design or documentation and requires code changes to address

Comments

@brianbancroft
Copy link
Contributor

brianbancroft commented May 9, 2021

Expected Behaviour

On mobile devices (or simulated), I would expect the Layer component to animate with the following props provided:

     <Layer
        position="left"
        modal={false}
        onEsc={() => setLayer(false)}
        onClickOutside={() => setLayer(false)}
      >

Actual Behaviour

Only animates in desktop [when the size in ResponsiveContext is not "small"]

https://codesandbox.io/s/grommet-layer-no-animate-mobile-hl9cr?file=/src/Layout.js&resolutionWidth=320&resolutionHeight=675

I am unsure whether this is a bug or is intended behaviour. If intended, I would be happy to change the documentation to make clear this edge.

Steps to Reproduce

  1. Check out codesandbox
  2. Click Menu icon on top of simulation to trigger the layer

Your Environment

  • Grommet version: 2.17.2
  • Browser Name and version: Chrome 90.0.4430.93
  • Operating System and version (desktop or mobile): MacOS Big Sur 11.2.3
@ShimiSun ShimiSun added the bug issue that does not match design or documentation and requires code changes to address label May 10, 2021
@jcfilben
Copy link
Collaborator

Closing since #5274 has been merged

@brianbancroft
Copy link
Contributor Author

Thanks @g4rry420!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug issue that does not match design or documentation and requires code changes to address
Projects
None yet
Development

No branches or pull requests

3 participants